Skip to content

Spirit Board Improvements #2912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Spirit Board Improvements #2912

merged 2 commits into from
Oct 17, 2024

Conversation

FoamyGuy
Copy link
Collaborator

A few more improvements based on feedback from JP.

  • Included the spirit_messages.txt file in the project so the user can modify an existing file instead of having to create it. This should make it also appear on the drive structure screenshots as well I believe.
  • Handle uppercase characters in the message by moving everything to lowercase before looking up the location in the dictionary map (which has all lowercase keys)
  • More gracefully handle invalid characters that aren't on the spirit board. Previously the code would raise an exception when it attempts to lookup the character in the locations dictionary. Now it will print out a message in the serial output and skip the invalid character moving on to the next character in the message.

@TheKitty TheKitty merged commit 045afc1 into adafruit:main Oct 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants